Skip to content

Update packages #7268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update packages #7268

wants to merge 8 commits into from
+664 −824

Conversation

madduci
Copy link
Contributor

@madduci madduci commented Sep 19, 2025 •
edited
Loading

Hi

I've performed an upgrade of many libraries to resolve important CVEs.

I had to change some code to address deprecated / removed / unused code.

Current Status: some tests are still failing, mostly due to dirty context, i am trying to correct them

I've also applied mvn spotless:apply, but the GitHub Action is still failing

@madduci madduci requested review from nathandoef, tadgh, jamesagnew and a team as code owners September 19, 2025 18:53
@robogary
Copy link
Contributor

This Pull Request has failed the formatting check

Please run mvn spotless:apply or mvn clean install -DskipTests to fix the formatting issues.

You can automate this auto-formatting process to execute on the git pre-push hook, by installing pre-commit and then calling pre-commit install --hook-type pre-push. This will cause formatting to run automatically whenever you push.

@madduci madduci requested a review from fil512 as a code owner September 25, 2025 07:12
@jamesagnew
Copy link
Collaborator

Hi @madduci - Thanks for the contribution! This looks to be failing quite a few CI tests though, it's not currently in a state that could be merged.

@madduci
Copy link
Contributor Author

madduci commented Oct 7, 2025

Hi @jamesagnew

yes after the upgrade of packages, some tests are failing, currently i don't know if the expected wrong actual values in tests are there because of the internal processing of the tinder-plugin, which seems to behave differently after the upgrade of some plugins/libraries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathandoef nathandoef Awaiting requested review from nathandoef nathandoef is a code owner

@tadgh tadgh Awaiting requested review from tadgh tadgh is a code owner

@jamesagnew jamesagnew Awaiting requested review from jamesagnew jamesagnew is a code owner

@michaelabuckley michaelabuckley Awaiting requested review from michaelabuckley michaelabuckley is a code owner

@fil512 fil512 Awaiting requested review from fil512 fil512 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madduci @robogary @jamesagnew